[PATCH] s3/vfs:stream_depots: Parse substitutions in streams-depot-directory path
jra at samba.org
Sat Mar 12 00:46:59 UTC 2016
On Fri, Mar 11, 2016 at 01:38:57AM +0000, Shyam Rathi wrote:
> Thanks Jeremy.
> I’ve made the change as per your suggestion.
> Updated patch attached.
LGTM. Reviewed-by: Jeremy Allison <jra at samba.org>
Can I get a second Team reviewer ?
> > On Mar 10, 2016, at 4:20 PM, Jeremy Allison <jra at samba.org> wrote:
> > On Fri, Mar 11, 2016 at 12:06:56AM +0000, Shyam Rathi wrote:
> >> Thanks Jeremy.
> >> ???rootdir??? is defined as ???const char *???, so passing it to TALLOC_FREE will be an issue. Is it a good idea to change it to ???char *???, or have a separate variable for the substitution and then copy it to ???rootdir????
> >> Which approach is more acceptable?
> > Change to char *. If it's talloced,
> > that's what it is.
More information about the samba-technical