Code readability (Was: [PATCH] More smb_filename cleanups.)

[Volker Lendecke]

On Fri, Mar 11, 2016 at 10:49:40AM +0100, Ralph Boehme wrote:
> > would it makes sense for code readability to add a macro in a prominent place:
> > 
> > #define isflagset(flagfield, flag) (((flagfield) & (flag)) == (flag))
> > 
> > then use:
> > 
> > !isflagset(fsp->posix_flags, FSP_POSIX_FLAGS_PATHNAMES)
> 
> I'd prefer the direct binary operator in front of me instead of adding
> a layer.

Same here.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de