[PATCH] s3/vfs:stream_depots: Parse substitutions in streams-depot-directory path

[Shyam Rathi]

Thanks Jeremy.

‘rootdir’ is defined as ‘const char *’, so passing it to TALLOC_FREE will be an issue. Is it a good idea to change it to ‘char *’, or have a separate variable for the substitution and then copy it to ‘rootdir’?

Which approach is more acceptable?

Regards,
-Shyam




> On Mar 10, 2016, at 1:50 PM, Jeremy Allison <jra at samba.org> wrote:
> 
> On Thu, Mar 10, 2016 at 09:40:18PM +0000, Shyam Rathi wrote:
>> Hello,
>> At present, substitutions in the streams directory path are ignored. Fix it by modifying 'stream_dir' function to call 'lp_parm_talloc_string' which internally calls 'lp_string' on the path.
>> 
>> Attached patch.
> 
> Don't you also need to add a TALLOC_FREE(rootdir);
> to the fail: exit path, and also the success path ?