[PATCH] An option in 'net ads dns' command to remove a DNS hostname

[Andreas Schneider]

On Thursday 10 March 2016 09:58:54 Uri Simchoni wrote:
> On 03/10/2016 09:49 AM, Andreas Schneider wrote:
> > On Tuesday 08 March 2016 02:12:27 Shyam Rathi wrote:
> >> Hello,
> > 
> > Hey!
> > 
> >> I did not find a way to remove a DNS hostname from a server using ‘net
> >> ads
> >> dns’ command. It has only two options, ‘register’ and ‘gethostbyname’.
> >> I’ve
> >> added a third option ‘unregister’ to remove a hostname as well, which can
> >> be used to revert the DNS entries added with ‘register’ option.
> > 
> > thank you very much for your patch!
> > 
> > I would like to have this covered with a test before we add this to our
> > codebase.
> > 
> > Uri, did we push your changes with a random client we join?
> > 
> > 	-- andreas
> 
> No, we didn't. Michael said he was reworking selftest to tear down the
> env between tests, which seemed like a better solution than hacking
> custom envs, and since the current join tests do not seem to be failing
> other tests, I didn't want to add a hack that does not solve any
> immediate problem, whilst a better solution is being worked on.

I think we should add it. Michael doesn't look he has time for this in the 
near future, and well, untested code is broken code.


We should revisit the tests once Michael has something working.


Agree?

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org