[PATCH] s3/utils/regedit.c: typo

Uri Simchoni uri at samba.org
Wed Mar 9 18:13:41 UTC 2016


On 03/09/2016 06:52 PM, Jeremy Allison wrote:
> On Wed, Mar 09, 2016 at 04:30:00PM +0100, Aurélien Aptel wrote:
>> Hi,
>>
>> Another PVS fix.
>>
>> The loop should exit on any case of Q.
>>
>> Please review&push.
>
> LGTM. Second Team reviewer please ?
>
RB+ me.
>> --
>> Aurélien Aptel / SUSE Labs Samba Team
>> GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
>> SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
>> GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG
>> Nürnberg)
>
>>  From 0f9dc444dd5a7b88cac4c5db603614b6d913c97b Mon Sep 17 00:00:00 2001
>> From: Aurelien Aptel <aaptel at suse.com>
>> Date: Wed, 9 Mar 2016 15:25:26 +0100
>> Subject: [PATCH] s3/utils/regedit.c: typo
>>
>> loop should exit on any case of Q.
>>
>> Signed-off-by: Aurelien Aptel <aaptel at suse.com>
>> ---
>>   source3/utils/regedit.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/source3/utils/regedit.c b/source3/utils/regedit.c
>> index 21437f4..9db63b9 100644
>> --- a/source3/utils/regedit.c
>> +++ b/source3/utils/regedit.c
>> @@ -748,7 +748,7 @@ static void display_window(TALLOC_CTX *mem_ctx, struct registry_context *ctx)
>>   		handle_main_input(regedit, key);
>>   		update_panels();
>>   		doupdate();
>> -	} while (key != 'q' || key == 'Q');
>> +	} while (key != 'q' && key != 'Q');
>>
>>   	endwin();
>>   }
>> --
>> 2.1.4
>>
>
>
>
>




More information about the samba-technical mailing list