[PATCH] s4/heimdal/lib/gssapi/mech/gss_compare_name.c: typo

Ira Cooper ira at wakeful.net
Wed Mar 9 17:50:26 UTC 2016


My bad.

Reviewed-by: Ira Cooper <ira at samba.org>

On Wed, Mar 9, 2016 at 12:48 PM, Aurélien Aptel <aaptel at suse.com> wrote:

> On Wed, 9 Mar 2016 12:40:17 -0500 Ira Cooper <ira at wakeful.net> wrote:
> > If name1 and name2 are different lengths, can this cause an
> > uninitialized memory read?
>
> The memcmp() is only executed if the left-hand side of the || is false
> i.e. when both length are equal.
>
> --
> Aurélien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
> SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG
> Nürnberg)
>


More information about the samba-technical mailing list