[PATCH] s4/heimdal/lib/gssapi/mech/gss_compare_name.c: typo

Ira Cooper ira at wakeful.net
Wed Mar 9 17:40:17 UTC 2016


If name1 and name2 are different lengths, can this cause an uninitialized
memory read?

-Ira

On Wed, Mar 9, 2016 at 12:35 PM, Aurélien Aptel <aaptel at suse.com> wrote:

> Hi,
>
> Another PVS fix.
>
> Make memcmp() compare the name1 and name2 value instead of comparing
> name1 with itself.
>
> This change is a bit special because it's in code imported from FreeBSD
> and I don't know if we sync often enough with them. Should we commit
> this here or in FreeBSD and sync with their libgssapi later?
>
> Thanks!
>
> --
> Aurélien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
> SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG
> Nürnberg)
>


More information about the samba-technical mailing list