[PATCH] s4/client/cifsdd.c: typo

Jeremy Allison jra at samba.org
Wed Mar 9 17:09:47 UTC 2016


On Wed, Mar 09, 2016 at 04:45:24PM +0100, Aurélien Aptel wrote:
> Hi,
> 
> Another PVS fix.
> 
> Fix redundant check, we want to check both "ibs" and "obs", not "ibs"
> twice.
> 
> Please review&push.

LGTM. Second Team reviewer please !

> -- 
> Aurélien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
> SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG
> Nürnberg)

> From 249745a30fc8aa0f5877a2c5fd79560f0ab2f844 Mon Sep 17 00:00:00 2001
> From: Aurelien Aptel <aaptel at suse.com>
> Date: Wed, 9 Mar 2016 11:37:44 +0100
> Subject: [PATCH] s4/client/cifsdd.c: typo
> 
> Signed-off-by: Aurelien Aptel <aaptel at suse.com>
> ---
>  source4/client/cifsdd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/source4/client/cifsdd.c b/source4/client/cifsdd.c
> index 48ffe18..980948a 100644
> --- a/source4/client/cifsdd.c
> +++ b/source4/client/cifsdd.c
> @@ -606,7 +606,7 @@ int main(int argc, const char ** argv)
>  	gensec_init();
>  	dump_args();
>  
> -	if (check_arg_numeric("ibs") == 0 || check_arg_numeric("ibs") == 0) {
> +	if (check_arg_numeric("ibs") == 0 || check_arg_numeric("obs") == 0) {
>  		fprintf(stderr, "%s: block sizes must be greater that zero\n",
>  				PROGNAME);
>  		exit(SYNTAX_EXIT_CODE);
> -- 
> 2.1.4
> 






More information about the samba-technical mailing list