[PATCH] ctdb-takeover: Do not kill smbd processes on releasing IP

Amitay Isaacs amitay at gmail.com
Sat Mar 5 03:15:10 UTC 2016


On Fri, Mar 4, 2016 at 7:39 PM, Martin Schwenke <martin at meltin.net> wrote:

> On Fri, 4 Mar 2016 17:16:41 +1100, Amitay Isaacs <amitay at gmail.com>
> wrote:
>
> > When CTDB on a node is releasing an IP address, CTDB kills the server
> side
> > TCP connection and also notifies Samba with SRVID_RELEASE_IP message.
> > Samba can take appropriate action based on closed connection and SRVID
> > notification.  There is no need to kill smbd processes that were serving
> > the released IP address.
> >
> > Please review and push.
>
> In ctdb_release_all_ips(), should we add a:
>
>   ctdb_daemon_send_message(ctdb, ctdb->pnn, CTDB_SRVID_RELEASE_IP, ...);
>
> before we remove the call to release_kill_clients()?
>
>
Yeah, good point.  Here's the second patch that sends the messages.

Amitay.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-ctdb-takeover-Inform-clients-when-dropping-all-IP-ad.patch
Type: application/text
Size: 1501 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160305/0531383a/0002-ctdb-takeover-Inform-clients-when-dropping-all-IP-ad.bin>


More information about the samba-technical mailing list