[PATCH] lib: Fix gencache_del

[Michael Adam]

On 2016-03-04 at 11:51 -0800, Jeremy Allison wrote:
> On Fri, Mar 04, 2016 at 08:35:38PM +0100, Michael Adam wrote:
> > On 2016-03-04 at 13:18 +0100, Volker Lendecke wrote:
> > > On Fri, Mar 04, 2016 at 08:15:51AM +0100, Volker Lendecke wrote:
> > > > On Thu, Mar 03, 2016 at 07:08:18PM +0100, Michael Adam wrote:
> > > > > Unfortunately, this fails make test due to a slight
> > > > > change in semantics of delete:
> > > > 
> > > > Attached find a patchset that survived a private autobuild for me.
> > > > 
> > > > Comments welcome!
> > > 
> > > Not a good day for me today. Working on the next version of this
> > > patchset.
> > > 
> > > Sorry for the noise,
> > 
> > Not sure if the changed semantics where
> > gencache_del was made idempotent are not
> > actually the better semantics for our
> > Samba code?
> 
> +1. I must confess I thought it already
> *was* idempotent :-).

I have just looked over the users.
I think we are fine taking your original
patch along with the testsuite patchlet
that I sent. Some callers (e.g. one in
idmap_cache) even deliberately ignore
the return code due to the missing
idempotence...

Cheers - Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160304/516fa86e/signature.sig>