[PATCH] Final changes to VFS functions to convert from const char * to const struct smb_filename *
rb at sernet.de
Fri Mar 4 17:52:11 UTC 2016
On Thu, Mar 03, 2016 at 05:15:32PM -0800, Jeremy Allison wrote:
> Last two, chown() and lchown(). Patch is in 4 pieces.
> 1). Fix bad call in vfs_netatalk(). lchown function was calling chown().
> 2). Modify chmod to take a const struct smb_filename * instead of const char *
> 3). Modify chmod to take a const struct smb_filename * instead of const char *
> 4). Simplify logic inside vfs_chown_fsp(). When creating the previous two
> patches I realized this was way too complex and if modified carelessly
> might cause a security issue (it doesn't have any issues btw). Much simpler now.
> That's the last of the VFS changes needed. Now I can
> concentrate on plumbing smb_filename through to all
> the places that currently use lp_posix_pathnames()
> and eliminating them !
> I carefully checked for errors I made in previous
> VFS patches (missing uncompiled modules, etc.) and
> couldn't spot any :-).
> Passes local make test !
> Please review and push if happy.
I'll take a look.
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
More information about the samba-technical