[PATCH] s4/torture/libnetapi/libnetapi_user.c: fix typo

Alexander Bokovoy ab at samba.org
Fri Mar 4 17:09:54 UTC 2016


On Fri, 04 Mar 2016, Aurélien Aptel wrote:
> Hi,
> 
> Another PVS fix, similar to a previous one. Misplaced closing paren +
> wrong sizeof().
> 
> Please review&push
> 
> Thanks!
> 
> -- 
> Aurélien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
> SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG
> Nürnberg)

> From 29f8811ea6ed0a729d53f625ac345728e8050049 Mon Sep 17 00:00:00 2001
> From: Aurelien Aptel <aaptel at suse.com>
> Date: Fri, 4 Mar 2016 09:29:48 +0100
> Subject: [PATCH 10/10] s4/torture/libnetapi/libnetapi_user.c: fix typo
> 
> fixed misplaced parenthesis and wrong sizeof().
> 
> Signed-off-by: Aurelien Aptel <aaptel at suse.com>
> ---
>  source4/torture/libnetapi/libnetapi_user.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/source4/torture/libnetapi/libnetapi_user.c b/source4/torture/libnetapi/libnetapi_user.c
> index 2afc1e5..be9cce9 100644
> --- a/source4/torture/libnetapi/libnetapi_user.c
> +++ b/source4/torture/libnetapi/libnetapi_user.c
> @@ -249,7 +249,7 @@ static NET_API_STATUS test_netusermodals(struct torture_context *tctx,
>  		return status;
>  	}
>  
> -	if (memcmp(u0, _u0, sizeof(u0) != 0)) {
> +	if (memcmp(u0, _u0, sizeof(*u0)) != 0)) {
This line needed a fix to balance brackets which was easy to miss. ;)

Re-pushed.

>  		torture_comment(tctx, "USER_MODALS_INFO_0 struct has changed!!!!\n");
>  		return -1;
>  	}
> -- 
> 2.1.4
> 




-- 
/ Alexander Bokovoy



More information about the samba-technical mailing list