[PATCH] vfs: Fix the vfs_gpfs build

Christof Schmitt cs at samba.org
Thu Mar 3 18:12:31 UTC 2016


Fixing the build first is important. Looking at the code in
vfs_gpfs_chmod now, i am wondering if we could just remove the copy of
the smb_fname. We could just use smb_fname for the stat and avoid the
copy. I will look into a patch to simplify this function.

Christof

On Thu, Mar 03, 2016 at 05:20:27PM +0100, Volker Lendecke wrote:
> Hi!
> 
> Review appreciated! (if it's not already on its way...)
> 
> Thanks, Volker
> 
> -- 
> SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
> phone: +49-551-370000-0, fax: +49-551-370000-9
> AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
> http://www.sernet.de, mailto:kontakt at sernet.de

> From db08ab6beebb91d166e6527d66aeed353604c3b2 Mon Sep 17 00:00:00 2001
> From: Volker Lendecke <vl at samba.org>
> Date: Thu, 3 Mar 2016 17:19:18 +0100
> Subject: [PATCH] vfs: Fix the vfs_gpfs build
> 
> Signed-off-by: Volker Lendecke <vl at samba.org>
> ---
>  source3/modules/vfs_gpfs.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/source3/modules/vfs_gpfs.c b/source3/modules/vfs_gpfs.c
> index af7fd17..cc17d2a 100644
> --- a/source3/modules/vfs_gpfs.c
> +++ b/source3/modules/vfs_gpfs.c
> @@ -1403,7 +1403,7 @@ static int vfs_gpfs_chmod(vfs_handle_struct *handle,
>  	struct smb_filename *smb_fname_cpath;
>  	int rc;
>  
> -	smb_fname_cpath = cp_smb_fname(talloc_tos(), smb_fname);
> +	smb_fname_cpath = cp_smb_filename(talloc_tos(), smb_fname);
>  	if (smb_fname_cpath == NULL) {
>  		errno = ENOMEM;
>  		return -1;
> -- 
> 1.7.9.5
> 




More information about the samba-technical mailing list