[PATCH] remove unnecessary cast to bool

Michael Adam obnox at samba.org
Thu Mar 3 16:02:57 UTC 2016


Review/push appreciated.

Thanks for the hint. Ralph!

Cheers - Michael
-------------- next part --------------
From bcc4dee0df78bc6b05bbb2fe80c1d286ef33c466 Mon Sep 17 00:00:00 2001
From: Michael Adam <obnox at samba.org>
Date: Thu, 3 Mar 2016 16:57:45 +0100
Subject: [PATCH] smbd:smb2: remove an unnecessary !! cast.

Casting to bool is done implcitly upon assignment.
Thanks to Ralph for pointing this out!

Signed-off-by: Michael Adam <obnox at samba.org>
---
 source3/smbd/smb2_create.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/source3/smbd/smb2_create.c b/source3/smbd/smb2_create.c
index 34e07ec..8c8794f 100644
--- a/source3/smbd/smb2_create.c
+++ b/source3/smbd/smb2_create.c
@@ -836,7 +836,7 @@ static struct tevent_req *smbd_smb2_create_send(TALLOC_CTX *mem_ctx,
 			hdr = SMBD_SMB2_IN_HDR_PTR(smb2req);
 			flags = IVAL(hdr, SMB2_HDR_FLAGS);
 			replay_operation =
-				!!(flags & SMB2_HDR_FLAG_REPLAY_OPERATION);
+				flags & SMB2_HDR_FLAG_REPLAY_OPERATION;
 
 			status = smb2srv_open_lookup_replay_cache(
 					smb2req->xconn, create_guid,
-- 
2.5.0

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160303/e4ced83b/signature.sig>


More information about the samba-technical mailing list