[PATCH] Fix chmod and chmod_acl VFS functions to take struct smb_filename * instead of const char *

Jeremy Allison jra at samba.org
Thu Mar 3 05:47:16 UTC 2016


On Thu, Mar 03, 2016 at 06:02:14AM +0100, Ralph Boehme wrote:
> On Wed, Mar 02, 2016 at 02:50:56PM -0800, Jeremy Allison wrote:
> > Two patches fixing a couple more functions fixed in my
> > quest to exterminate lp_posix_pathnames() :-).
> 
> pushed with three minor fixes:

Oh thanks. Fat fingers on uncompiled modules strike again :-(.

Cheers,

	Jeremy.

> diff --git a/source3/modules/vfs_snapper.c
> b/source3/modules/vfs_snapper.c
> index 2e04a48..fb99369 100644
> --- a/source3/modules/vfs_snapper.c
> +++ b/source3/modules/vfs_snapper.c
> @@ -2216,14 +2216,14 @@ static int
> snapper_gmt_unlink(vfs_handle_struct *handle,
>  }
>  
>  static int snapper_gmt_chmod(vfs_handle_struct *handle,
> -                       const struct smb_fname *smb_fname,
> +                       const struct smb_filename *smb_fname,
>                         mode_t mode)
>  {
>         time_t timestamp;
>         char *stripped = NULL;
>         int ret, saved_errno;
>         char *conv = NULL;
> -       struct smb_fname *conv_smb_fname = NULL;
> +       struct smb_filename *conv_smb_fname = NULL;
>  
>         if (!snapper_gmt_strip_snapshot(talloc_tos(),
>                                 handle,
> @@ -2242,7 +2242,7 @@ static int snapper_gmt_chmod(vfs_handle_struct
>                                 *handle,
>                 return -1;
>         }
>         conv_smb_fname = synthetic_smb_fname(talloc_tos(),
> -                                       conv
> +                                       conv,
>                                         NULL,
>                                         NULL);
>         if (conv_smb_fname == NULL) {
> 
> -Ralph
> 
> -- 
> SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
> phone: +49-551-370000-0, fax: +49-551-370000-9
> AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
> http://www.sernet.de,mailto:kontakt@sernet.de



More information about the samba-technical mailing list