[PATCHES] smb3 create replay (for multi-channel)

Michael Adam obnox at samba.org
Wed Mar 2 20:54:04 UTC 2016


On 2016-03-02 at 12:05 -0800, Jeremy Allison wrote:
> On Tue, Mar 01, 2016 at 02:15:33AM +0100, Michael Adam wrote:
> > Hi all,
> > 
> > here is an important step toward multi channel:
> > Implementation of create replay.
> > 
> > - This patchset includes the previously sent
> >   patches for dbwrap_purge as the first patches.
> > 
> > - It then reworks several replay tests that work
> >   on a single channel by splitting them up
> >   into more easily understandable smaller tests
> >   and extending them for better coverage.
> > 
> > - Next, preparation in smbXsrv_open are done
> >   to implement a replay cache to find an open
> >   based on the create_guid.
> > 
> > - finally, these mechanisms are used in smb2_create
> >   to implement create replay.
> > 
> > Review appreciated.
> 
> LGTM - with the first (already applied) patches
> removed ! Pushed.

Thanks a lot Jeremy!

I was about to push an updated patchset with the
already pushed patches removed, a few cosmetic
cleanups and more importantly, some additional
new torture tests and (fairly minor) adaptions
of the server code for the corner cases.

Since your build has not been started, would
you like me to send a follow up patch or
would you consider pushing a revised patchset
over your currently waiting autobuild?

Thanks again and apologies for the inconvenience!...

Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160302/eec2b71f/signature.sig>


More information about the samba-technical mailing list