smbget's -P option

[Andreas Schneider]

On Tuesday 23 February 2016 12:45:40 Christian Ambach wrote:
> Hi Andreas,
> 
> Am 22.02.16 um 09:06 schrieb Andreas Schneider:
> >> Debian and Ubuntu ship with a version of popt that fixes the problem we
> >> are hitting in smbget (see
> >> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=217602).
> >> Patch 7 in the patchset applies the same change to our copy of popt.
> >> While looking into this, I found another problem with the option parsing
> >> of smbget that I also included a patch for.
> >> So some patches in the set need review, the others are included for
> >> completeness and so they can all be pushed together.
> > 
> > What do you think about the attached patch?
> 
> It broke option parsing for me, I then got the same error that you got
> without the patch.
> So I would give up on making popt work with bool, especially as we
> cannot make sure that the popt libs on the systems we compile on will
> work properly. I would need to add a configure check to find out if its
> good or not.
> So let's rather spend the few more entries in the switch statement and
> set the options there.

Do you want to get this into 4.4.0?


	-- andreas

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org