[PATCH] CTDB local daemons test improvements
Martin Schwenke
martin at meltin.net
Tue Mar 1 03:27:49 UTC 2016
On Tue, 1 Mar 2016 14:20:02 +1100, Amitay Isaacs <amitay at gmail.com>
wrote:
> On Mon, Feb 29, 2016 at 8:22 PM, Martin Schwenke <martin at meltin.net> wrote:
>
> > Updates the local daemons test code to use ctdbd_wrapper to start the
> > daemons instead of hardcoding command-line options.
> >
> > The main point is to allow options to the local daemons to be easily
> > overridden via the environment. This could be done in individual tests
> > when starting CTDB and also on the command-line when doing initial
> > developer testing.
> >
> > This also does trivial implicit testing of ctdbd_wrapper, which is
> > relatively untested. However, allowing the configuration file to be
> > specified opens up the possibility of actually writing tests for it!
> >
> > Please review and maybe push...
>
> Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Pushed...
peace & happiness,
martin
More information about the samba-technical
mailing list