[PATCH] Improve talloc performance

Michael Adam obnox at samba.org
Thu Jun 30 22:39:15 UTC 2016


On 2016-06-30 at 15:16 -0700, Jeremy Allison wrote:
> On Thu, Jun 30, 2016 at 11:52:22PM +0200, Michael Adam wrote:
> > 
> > From a superficial glance, the patches look clean,
> > straight and reasonably-sized. But one cosmetic comment:
> > you seem to have dropped the actual patch authorship.
> > At least the singoff and review tags seem to imply that. :-)
> 
> Didn't think so - this is Andrew's original work
> split up (and somewhat renamed) by me. I thought
> I'd got that correct. What did I mess up ?

The reworked patches all carry
"From: Jeremy Allison <jra at samba.org>"
so if I read that right, they'll all have you as author.

If you want Andrew to be listed as the author, you'd need to do

  git commit --author="Andrew Bartlett <abartlet at samba.org>" ...

or similar, etc.

Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160701/984773d6/signature.sig>


More information about the samba-technical mailing list