[PATCH] Improve talloc performance

Jeremy Allison jra at samba.org
Wed Jun 29 23:55:23 UTC 2016

On Fri, Jun 17, 2016 at 05:12:12PM -0700, Jeremy Allison wrote:
> On Fri, Jun 17, 2016 at 09:50:27PM +1200, Andrew Bartlett wrote:
> > Attached is a patch to improve talloc performance, by calling
> > talloc_chunk_from_ptr() less often.  I'm impressed by how much can be
> > gained!  
> > 
> > Please carefully review!
> I'm going through this right now, but one thing
> that has to be done is to split this into a set of smaller
> changesets as the chunks are too large to carefully parse
> mentally (at least for me). Too much change per patchset.

OK, split this into an 11-patch set, with each change
being somewhat clearer and smaller (IMHO of course :-).

Your original patchset had one error (missing setting
the .name in the replacement for talloc_vasprintf(),
and a couple of places where you added code, then removed
it again.

I'm still running tests on it at the moment, but at
least it compiles :-).

I'll post for your review once I've gotten it past
testing !



More information about the samba-technical mailing list