[PATCH] shadow_copy2: Allow configurable prefix for snapshots
rjoseph at redhat.com
Tue Jun 28 15:31:34 UTC 2016
Sorry for this late update on this thread. Due to vacation and other
priorities this left unattended.
As Uri recommended I added test cases to cover shadow:format. Also
addressed review comments from others.
Please go through the patch and let me know if it looks OK or not.
Thanks & Regards,
On Thu, May 12, 2016 at 5:34 PM, Michael Adam <obnox at samba.org> wrote:
> On 2016-05-12 at 16:24 +0530, Rajesh Joseph wrote:
> > On Wed, May 11, 2016 at 3:00 AM, Michael Adam <obnox at samba.org> wrote:
> > >
> > > The twrp context is the smb2-way of requesting
> > > previous versions. It is conceptually much cleaner than
> > > the horrbile arbitrariness of injecting an @GMT-token
> > > into the path somewhere... :-) And we do not ignore it,
> > > but we treat it by (hold-your-breath) ... injecting a
> > > correpsonding @GMT-component into the path (as the first
> > > component). See source3/smbd/smb2_create.c, line 900 ff.
> > > This is ugly but it works. And it ensures currently, that
> > > we enter the module code with the same kind of data, even
> > > if the client used twrp.
> > >
> > Frankly speaking I have not looked into "time warp". I am not sure
> > how will it impact my current patch. I will take a look at this and
> > get back to you on this.
> As twrp time stamps are converted to @GMT path components before
> hitting the vfs, it does not impact your patch at all! :-)
> Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 35496 bytes
Desc: not available
More information about the samba-technical