[Patch] Fix the ";binary" suffix behavior

Niklas Abel niklas.abel at lsexperts.de
Mon Jun 27 16:59:07 UTC 2016


On 06/27/2016 07:06 AM, Andrew Bartlett wrote:
> On Mon, 2016-06-20 at 23:53 +0200, Niklas Abel wrote:
>> Hey,
>> I have written a new patch to fix the behavior previously discussed
>> at
>> https://lists.samba.org/archive/samba-technical/2016-May/114242.html
>> It modifies search requests with a ";binary" suffix.
>> If an attributes’ suffix is ";binary" the binary part will simple be
>> stripped away.
> Can we first check if this is needed before we do any work?  That is,
> check for ; where we check for . on line 482?
> We don't want to do the work for the 99.99% of cases where this isn't
> supplied by the client.  
Yes of course, I have changed it in the new patch file.
> Then you can replace the call
> to str_list_copy_const() on line 523.
We have to replace the req->op.search.attrs, its not enough to clean the
list for attrs2.
> Finally, just make sure to match our coding style and indentation.
>  README.Coding has the details.
I have changed the indentation, sorry for that.
>> The behavior is now fixed as suggested in the resolve_oids.c
>> @Andrew I hope the Python test is what you was looking for.
> That much is OK. 
> You are doing well, and are really close!
> Thanks!
> Andrew Bartlett
Thanks for your reply. :-)

Niklas Abel

Niklas Abel (IT Security Consultant), http://www.lsexperts.de
LSE Leading Security Experts GmbH, Postfach 100121, 64201 Darmstadt
Tel: +49 6151 86086-261, Fax: -299, Mobil: +49 151 26467737
Unternehmenssitz: Weiterstadt, Amtsgericht Darmstadt: HRB8649
Geschäftsführer: Nils Manegold, Oliver Michel, Arved Graf von Stackelberg, Sven Walther

-------------- next part --------------
A non-text attachment was scrubbed...
Name: binary_suffix.patch
Type: text/x-patch
Size: 4397 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160627/b092fc4c/binary_suffix.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3958 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160627/b092fc4c/smime.bin>

More information about the samba-technical mailing list