Patch: source4/selftests etc, add a test for net ads dns register et al

[Richard Sharpe]

On Sun, Jun 26, 2016 at 11:23 PM, Ralph Boehme <slow at samba.org> wrote:
> Hi!
>
> On Sun, Jun 26, 2016 at 08:08:28AM -0700, Richard Sharpe wrote:
>> @@ -672,7 +673,7 @@ for env in ["ad_dc_ntvfs", "s4member", "rodc", "promoted_dc", "ad_dc", "ad_membe
>>  #
>>  # KDC Tests
>>  #
>> -
>> +
>>  # This test is for users cached at the RODC
>>  plansmbtorture4testsuite('krb5.kdc', "rodc", ['ncacn_np:$SERVER_IP', "-k", "yes", '-Utestdenied%$PASSWORD',
>>                                                '--workgroup=$DOMAIN', '--realm=$REALM',
>
> can you remove this hunk?
>
>> +CONFIG="--configfile=$PREFIX/etc/smb.conf"
>> +export CONFIG
>
> it seems this is not needed for this test, at least the test still
> works after removing these two lines.
>
>> +testit "machine account should be able to add a DNS entry net ads
>> dns register membername.$REALM $IPADDRMAC -P " $net_tool ads dns
>> register membername.$REALM $IPADDRMAC -P -d 10 || failed=`expr
>> $failed + 1`
>
> I guess the "-d 10" is a relict from testing?
>
> If you're ok with these three changes feel free to add my rb and push.

OK, fixed them all, including putting back the line with three spaces
... sorry for the noise.

-- 
Regards,
Richard Sharpe
(何以解憂？唯有杜康。--曹操)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-source4-selftests-test-net-ads-dns-register.patch
Type: text/x-patch
Size: 4865 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160627/146c3cfa/0001-source4-selftests-test-net-ads-dns-register.bin>