Patch: source4/selftests etc, add a test for net ads dns register et al

Ralph Boehme slow at samba.org
Mon Jun 27 06:23:35 UTC 2016


Hi!

On Sun, Jun 26, 2016 at 08:08:28AM -0700, Richard Sharpe wrote:
> @@ -672,7 +673,7 @@ for env in ["ad_dc_ntvfs", "s4member", "rodc", "promoted_dc", "ad_dc", "ad_membe
>  #
>  # KDC Tests
>  #
> -    
> + 
>  # This test is for users cached at the RODC
>  plansmbtorture4testsuite('krb5.kdc', "rodc", ['ncacn_np:$SERVER_IP', "-k", "yes", '-Utestdenied%$PASSWORD',
>                                                '--workgroup=$DOMAIN', '--realm=$REALM',

can you remove this hunk?

> +CONFIG="--configfile=$PREFIX/etc/smb.conf"
> +export CONFIG

it seems this is not needed for this test, at least the test still
works after removing these two lines.

> +testit "machine account should be able to add a DNS entry net ads
> dns register membername.$REALM $IPADDRMAC -P " $net_tool ads dns
> register membername.$REALM $IPADDRMAC -P -d 10 || failed=`expr
> $failed + 1`

I guess the "-d 10" is a relict from testing?

If you're ok with these three changes feel free to add my rb and push.

Cheerio!
-slow



More information about the samba-technical mailing list