Improve badPwdCount, lastLogon and logonCount updates

Stefan Metzmacher metze at samba.org
Mon Jun 27 05:25:02 UTC 2016


Hi Andrew,

>> here're some patches to improve the badPwdCount, lastLogon
>> and logonCount updates.
>>
>> See
>> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/
>> master4-smart-base
>> This is on top of
>> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/
>> master4-pwdlastset.
>> I don't know if it would also apply independently...
>>
>> We may need to add some BUG: markers, but you can start the review...
> 
> I've reviewed the bulk of these for pwdLastSet, and have started an
> autobuild with them, except for the code to force specific
> replPropertyMetaData values, which both didn't seem to be related and
> broke the repl_move test.

Can you be more specific about that? what did you skip? What did it break?

It seems that the repl_move test is flakey, like other related ones.

metze at sn-devel-144:/home/autobuild/autobuild.flakey$ tail --lines=50
2016-06-*/samba.stdout | grep UNEXPECTED| sort

UNEXPECTED(error):
samba4.drs.replica_sync.python(promoted_dc).replica_sync.DrsReplicaSyncTestCase.test_ReplConflictsRemoteWin_with_child(promoted_dc:local)
UNEXPECTED(error):
samba4.drs.repl_move.python(promoted_dc).repl_move.DrsMoveBetweenTreeOfObjectTestCase.test_ReplicateAddInConflictOU_time(promoted_dc)
UNEXPECTED(error):
samba4.drs.repl_move.python(promoted_dc).repl_move.DrsMoveObjectTestCase.test_ReplicateMoveObject11(promoted_dc)
UNEXPECTED(error):
samba4.drs.repl_move.python(promoted_dc).repl_move.DrsMoveObjectTestCase.test_ReplicateMoveObject2(promoted_dc)
UNEXPECTED(error):
samba4.drs.repl_move.python(promoted_dc).repl_move.DrsMoveObjectTestCase.test_ReplicateMoveObject3(promoted_dc)
UNEXPECTED(error):
samba4.drs.repl_schema.python(promoted_dc).repl_schema.DrsReplSchemaTestCase.test_attribute_on_ou(promoted_dc)
UNEXPECTED(error):
samba4.drs.repl_schema.python(promoted_dc).repl_schema.DrsReplSchemaTestCase.test_classWithCustomAttribute(promoted_dc)
UNEXPECTED(error):
samba4.drs.repl_schema.python(promoted_dc).repl_schema.DrsReplSchemaTestCase.test_classWithCustomAttribute(promoted_dc)
UNEXPECTED(error):
samba4.drs.repl_schema.python(promoted_dc).repl_schema.DrsReplSchemaTestCase.test_classWithCustomAttribute(promoted_dc)
UNEXPECTED(error):
samba4.drs.repl_schema.python(promoted_dc).repl_schema.DrsReplSchemaTestCase.test_classWithCustomAttribute(promoted_dc)
UNEXPECTED(error):
samba4.drs.repl_schema.python(promoted_dc).repl_schema.DrsReplSchemaTestCase.test_classWithCustomAttribute(promoted_dc)
UNEXPECTED(error):
samba4.drs.repl_schema.python(promoted_dc).repl_schema.DrsReplSchemaTestCase.test_classWithCustomAttribute(promoted_dc)
UNEXPECTED(error):
samba4.drs.repl_schema.python(promoted_dc).repl_schema.DrsReplSchemaTestCase.test_classWithCustomAttribute(promoted_dc)
UNEXPECTED(error):
samba4.drs.repl_schema.python(promoted_dc).repl_schema.DrsReplSchemaTestCase.test_classWithCustomAttribute(promoted_dc)
UNEXPECTED(error):
samba4.drs.repl_schema.python(promoted_dc).repl_schema.DrsReplSchemaTestCase.test_classWithCustomAttribute(promoted_dc)
UNEXPECTED(error):
samba.tests.dns_forwarder.__main__.TestDnsForwarding.test_cname(fl2003dc:local)
UNEXPECTED(error):
samba.tests.dns_forwarder.__main__.TestDnsForwarding.test_cname(fl2003dc:local)
UNEXPECTED(error):
samba.tests.dns_forwarder.__main__.TestDnsForwarding.test_cname(fl2003dc:local)
UNEXPECTED(error):
samba.tests.dns_forwarder.__main__.TestDnsForwarding.test_cname(fl2003dc:local)
UNEXPECTED(failure): samba3.blackbox.smbclient_s3.plain (nt4_dc).sending
a message to the remote server(nt4_dc)
UNEXPECTED(failure): samba3.blackbox.smbclient_tar (fileserver).create,
incremental with -g(fileserver)
UNEXPECTED(failure): samba3.blackbox.smbclient_tar (fileserver).create,
incremental with -g(fileserver)
UNEXPECTED(failure): samba3.blackbox.smbclient_tar (fileserver).create,
incremental with tarmode(fileserver)
UNEXPECTED(failure): samba3.blackbox.smbclient_tar (fileserver).create,
incremental with tarmode(fileserver)
UNEXPECTED(failure): samba3.blackbox.smbclient_tar (fileserver).create,
reset archived files with -a(fileserver)
UNEXPECTED(failure): samba3.blackbox.smbclient_tar (fileserver).create,
reset archived files with -a(fileserver)
UNEXPECTED(failure): samba3.blackbox.smbclient_tar (fileserver).create,
reset archived files with -a(fileserver)
UNEXPECTED(failure): samba3.blackbox.smbclient_tar (fileserver).create,
reset archived files with -a(fileserver)
UNEXPECTED(failure): samba3.blackbox.smbclient_tar (fileserver).create,
reset archived files with -a(fileserver)
UNEXPECTED(failure): samba3.blackbox.smbclient_tar (fileserver).create,
reset archived files with -a(fileserver)
UNEXPECTED(failure): samba3.blackbox.smbclient_tar (fileserver).create,
reset archived files with -a(fileserver)
UNEXPECTED(failure): samba3.blackbox.smbclient_tar (fileserver).create,
reset archived files with -a(fileserver)
UNEXPECTED(failure): samba3.blackbox.smbclient_tar (fileserver).create,
reset archived files with -a(fileserver)
UNEXPECTED(failure): samba3.blackbox.smbclient_tar (fileserver).create,
reset archived files with -a(fileserver)
UNEXPECTED(failure): samba3.blackbox.smbclient_tar (fileserver).create,
reset archived files with -a(fileserver)
UNEXPECTED(failure): samba3.blackbox.smbclient_tar (fileserver).create,
reset archived files with -a(fileserver)
UNEXPECTED(failure): samba3.blackbox.smbclient_tar (fileserver).create,
reset archived files with -a(fileserver)
UNEXPECTED(failure): samba3.blackbox.smbclient_tar (fileserver).create,
reset archived files with -a(fileserver)
UNEXPECTED(failure): samba3.blackbox.smbclient_tar (fileserver).create,
reset archived files with tarmode(fileserver)
UNEXPECTED(failure): samba3.rpc.spoolss.printer.addprinterex.sd(ad_dc)
UNEXPECTED(failure): samba3.rpc.spoolss.printer.addprinter.sd(ad_dc)
UNEXPECTED(failure): samba3.rpc.spoolss.printer.addprinter.sd(ad_dc)
UNEXPECTED(failure): samba4.rpc.backupkey with
seal.backupkey.server_wrap_decrypt_wrong_r2(ad_dc_ntvfs)
UNEXPECTED(failure): samba4.rpc.cracknames on ncacn_ip_tcp with
seal.cracknames.cracknames-test(ad_dc_ntvfs)
UNEXPECTED(failure): samba4.rpc.cracknames on ncacn_ip_tcp with
seal.cracknames.cracknames-test(ad_dc_ntvfs)
UNEXPECTED(failure):
samba.tests.dns_forwarder.__main__.TestDnsForwarding.test_single_forwarder(fl2003dc:local)


> Thanks for your patience.  I'm continuing my review of the rest of
> msater4-smart-tmp, which seems to be where the lastLogon and logonCount
> patches are.

I reordered the patchsets, while adding the BUG markers.

It's now like this:

master4-pwdlastset => master4-smart-ok => master4-smart-tmp
                                       => master4-gpgme

These are all ready from my side.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160627/a14b6bf9/signature.sig>


More information about the samba-technical mailing list