source4/scripting: add an option to samba_dnsupdate to add ns records.
abartlet at samba.org
Sun Jun 26 23:32:13 UTC 2016
On Sun, 2016-06-26 at 12:51 -0700, Richard Sharpe wrote:
> On Sun, Jun 26, 2016 at 12:24 PM, Andrew Bartlett <abartlet at samba.org
> > wrote:
> > On Sun, 2016-06-26 at 09:35 -0700, Richard Sharpe wrote:
> > >
> > > You are correct. That change is totally unneeded. I have tested
> > > the
> > > self test environment with it reverted and things work correctly.
> > > In
> > > addition, that was not being called from anywhere anyway.
> > >
> > > For some reason the repository I was using did not contain the
> > > change
> > > you mentioned when I first started on this journey.
> > Indeed, Garming and I worked to get that in because of your
> > interest,
> > but it did take a little while to get into master.
> > >
> > > Attached is a patch to revert that change.
> > Great. Is this alternative OK? I've produced it using 'git
> > revert' to
> > keep things in our typical style and make it a true revert, moved
> > over
> > the rest of your commit message and added a sign-of by us both.
> Yes, this is fine. I can't push it at the moment because I already
> have an autobuild with Andreas' fix for systemd-230 going.
Thanks! I have it in my autobuild queue.
Authentication Developer, Samba Team https://samba.org
Samba Development and Support, Catalyst IT
More information about the samba-technical