tevent_abort_nesting crash in idmap_ad

Ralph Boehme slow at samba.org
Fri Jun 24 16:14:44 UTC 2016


On Fri, Jun 24, 2016 at 09:10:04AM -0700, Jeremy Allison wrote:
> On Fri, Jun 24, 2016 at 05:56:00PM +0200, Ralph Boehme wrote:
> > On Fri, Jun 24, 2016 at 05:48:24PM +0200, Volker Lendecke wrote:
> > > Please remove this again. NOW.
> > 
> > your code, you insist, so be it. Pushed to autobuild.
> 
> Hang on a minute - what will break with this revert ?

nothing I guess. But it seems to be the only short term solution for
the crash in idmap_ad that is caused by Volker's idmap_ad rewrite to
use tdlap. tldap uses gensec uses nested event loop -> *boom*

> Yes I know it's broken right now due to the nested
> event loops in gensec, but I'd like to know what
> we're losing by doing a revert here ?
> 
> Can we wait until at least next week and people have
> had time to look at is before taking drastic action
> like a big revert please ?
> 
> Long term of course, nested event loops Have. To. GO !

Cheerio!
-slow



More information about the samba-technical mailing list