[PATCH] Fix smbclient against Azure SMB2 server.

Uri Simchoni uri at samba.org
Wed Jun 22 04:37:33 UTC 2016


On 06/22/2016 01:57 AM, Jeremy Allison wrote:
> Discovered against the Microsoft Azure SMB2 server.
> 
> Doing :
> 
> smbclient //azure/share -mSMB3
>> mkdir test
>> cd test
>> ls
>   .                                   D        0  Tue Jun 21 14:59:16 2016
>   ..                                  D        0  Tue Jun 21 14:59:16 2016
> Error in dskattr: NT_STATUS_OBJECT_NAME_INVALID
> 
> smbclient passes the string "\\test\\" (current directory in smbclient) to cli_smb2_dskattr().
> 
> Fix attached.
> 
> BUG: https://bugzilla.samba.org/show_bug.cgi?id=11986
> 
> Please review and push !
> 
> Cheers,
> 
> 	Jeremy.
> 

LGTM- pushed!

Is anyone aware of a torture test that test for handling of the '\' at
the end of the path? Such a test may stop testing by this change because
the client sanitizes the path - I couldn't find any.




More information about the samba-technical mailing list