[PATCH] Fix pwdLastSet behaviour in regards to Windows

Stefan Metzmacher metze at samba.org
Mon Jun 20 20:46:36 UTC 2016


Hi Andrew,

>>> Please avoid changing the existing tests, they should continue to
>>> work
>>> as is.
>>
>> The idea with the test changes (that is, what I asked for) was to split
>> it up so that it was unit tests covering the same code paths, then new
>> tests to show the fix.  I think we both agree on the need to be very
>> careful when changing the tests.  I understand they were run against
>> Windows 2012R2.
> 
> If you want the tiny tests, then please add them as new tests.

I finished patches for this, it was much harder than expected,
but I think I got it right in the end.

See
https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-pwdlastset

The only missing thing are the BUG: markers in the commit messages.

This is based on my
https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-gpgme
branch, as there's a little conflict (we could easily change the order).

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160620/2b53905d/signature.sig>


More information about the samba-technical mailing list