[PATCH] ctdb: simplify logic (Re: [PATCH] Fixes related to ctdb command line option --nosetsched)

Michael Adam obnox at samba.org
Mon Jun 20 14:57:04 UTC 2016


On 2016-06-21 at 00:39 +1000, Amitay Isaacs wrote:
> On Tue, Jun 21, 2016 at 12:29 AM, Michael Adam <obnox at samba.org> wrote:
> >
> > No need, but how about this:
> >
> >         ctdb->do_setsched = (options.nosetsched != 1);
> >         if (ctdb->valgrinding) {
> >                 ctdb->do_setsched = false;
> >         }
> >
> > That makes it clear what is the rule
> > and what is the exception.
> >
> 
> This one is definitely much better. Thanks. :-)
> 
> Reviewed-by: me

Thanks. I will push it once the other patchset
has landed (or with it if it fails again). :-)

Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160620/d6ce5efa/signature.sig>


More information about the samba-technical mailing list