[PATCH] ctdb: simplify logic (Re: [PATCH] Fixes related to ctdb command line option --nosetsched)

Amitay Isaacs amitay at gmail.com
Mon Jun 20 14:13:12 UTC 2016

On Mon, Jun 20, 2016 at 7:39 PM, Michael Adam <obnox at samba.org> wrote:

> Hi,
> attached find a follow-up patch to this patchset that
> simplifies a bool assignment. Imho it reads more
> naturally like this.
> Review appreciated!
> Michael

I prefer the long form when multiple conditions are involved.  It makes
easier for me to parse and make less mistakes.  I don't think expressions
with double negatives read naturally.  But if you really free strongly
about the patch, someone else can review and push it.


More information about the samba-technical mailing list