[PATCHSET] Factor out common KDC infrastructure

Jeremy Allison jra at samba.org
Fri Jun 17 19:23:35 UTC 2016

On Fri, Jun 17, 2016 at 10:33:49AM +0200, Volker Lendecke wrote:
> On Thu, Jun 16, 2016 at 04:54:06PM +0200, Andreas Schneider wrote:
> > On Thursday, 16 June 2016 16:50:37 CEST Andreas Schneider wrote:
> > > Hello,
> > 
> > Now with a patch :)
> Looks very good from my point of view. If I had done more in the KDC
> area, I'd give you a Reviewed-by.

I fear nothing ! :-).

I won't get into the politics of it, or merging back from
newer Heimdal versions (*are* there newer versions ?) but
the code changes look clear and clean.

One extra change was required for build though - I don't
have ldb installed outside of samba on my system so it
also requires:

diff --git a/source4/kdc/wscript_build b/source4/kdc/wscript_build
index 3182b73..762e433 100755
--- a/source4/kdc/wscript_build
+++ b/source4/kdc/wscript_build
@@ -48,6 +48,7 @@ bld.SAMBA_SUBSYSTEM('KDC-SERVER',
+                        ldb

in order for source4/kdc/kdc-proxy.c to build (otherwise
it can't find ldb.h).

Reviewed-by: Jeremy Allison <jra at samba.org>


More information about the samba-technical mailing list