[PATCH] DNS TKEY/TSIG handling, bug 11520

Jeremy Allison jra at samba.org
Wed Jun 15 22:13:22 UTC 2016


On Thu, Jun 16, 2016 at 09:31:27AM +1200, Garming Sam wrote:
> Reviewed and pushed. Autobuild has been rather unkind, for whatever
> random failures, so I've dropped everything else I was going to push and
> try to finally get this in.

Yeah, I just had 2 random failures pushing this :-(.

I was pushing with one minor fix (attached). If
you end up being able to push the pristine
version I'll get this reviewed as a patch on
top.

Jeremy.

In fix:

PATCH 07/12] s4/dns_server: ensure we store the key name in error

Change:

 +		state->key_name = talloc_strdup(state->mem_ctx,
 +						state->tsig->name);

to:

 +		state->key_name = talloc_strdup(state->mem_ctx,
 +						state->tsig->name);
 +		if (state->key_name == NULL) {
 +			return WERR_NOMEM;
 +		}




More information about the samba-technical mailing list