[PATCH] CTDB recovery lock improvements

Andreas Schneider asn at samba.org
Tue Jun 14 07:57:53 UTC 2016

On Monday, 13 June 2016 19:14:37 CEST Aurélien Aptel wrote:
> Because many things in smbd are async I guess there could be a
> race condition between setting the flag and checking it. The fact that
> the test that resets the archive flag is also sometime failing makes me
> think this is probably the right explanation.
> We could start by adding a sleep() call between the setting
> and the checking, in the test suite (see attached patch).


the difference might be that autobuild runs completely in memory, not on disk! 

However we try to avoid adding more sleeps in the source code especially so 
long ones. Autobuilds alread runs 2,5 hours we don't need to extend it.

So a check (stat()) in a loop with usleep() is preferred.

	-- andreas

Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org

More information about the samba-technical mailing list