[PATCH] DNS TKEY/TSIG handling, bug 11520

[Ralph Boehme]

On Thu, Jun 09, 2016 at 11:29:16AM +0200, Ralph Boehme wrote:
> On Sat, Jun 04, 2016 at 12:09:14AM +1200, garming at catalyst.net.nz wrote:
> > I think that addresses everything on my end.
> >
> > You can put my review on the last patch.
> 
> attached is the final patchset with a minor cleanup in the test. The
> change from the previously reviewed version is:
> 
> --- a/python/samba/tests/dns_tkey.py
> +++ b/python/samba/tests/dns_tkey.py
> @@ -365,10 +365,6 @@ class DNSTest(tests.TestCase):
>          packet.additional = additional
>          packet.arcount = 1
>  
> -    def remove_tsig_rec(self, packet):
> -        packet.additional = []
> -        packet.arcount = 0
> -
>      def search_record(self, name):
>          p = self.make_name_packet(dns.DNS_OPCODE_QUERY)
>          questions = []
> @@ -472,7 +468,6 @@ class TestDNSUpdates(DNSTest):
>          (response, response_p) = self.dns_transaction_udp(p,
>          self.server_ip)
>          self.assert_dns_rcode_equals(response, dns.DNS_RCODE_OK)
>          self.verify_packet(response, response_p, mac)
> -        self.remove_tsig_rec(p)
>  
>          # Check the record is around
>          rcode = self.search_record(self.newrecname)
> 
> The call to remove_tsig_rec wasn't needed anymore and so the function
> was obsolete.
> 
> Please review and push if ok. Thanks!

just in case this got lost: ping. :)

Cheerio!
-slow