Questions regarding vfs module development

Jeremy Allison jra at samba.org
Thu Jun 9 18:37:18 UTC 2016


On Thu, Jun 09, 2016 at 09:16:40AM -0600, Trever L. Adams wrote:
> On 06/08/2016 12:27 PM, Jeremy Allison wrote:
> > On Wed, Jun 08, 2016 at 12:15:40PM -0600, Trever L. Adams wrote:
> >>
> >> bool parent_dirname(TALLOC_CTX *mem_ctx, const char *dir, char **parent,
> >>                     const char **name)
> >>
> >> So, as I read the code, dir would be smb_fname->base_name and dirname
> >> results would be in parent while name would be basename reults. Do I
> >> have that correctly? Additionally, unlike POSIX definition it appears
> >> that this function does NOT modify the original under any circumstances
> >> and I must also TALLOC_FREE the results. Is this correct?
> > You only have to free parent, not name. name points to a
> > substring in the talloc'ed parent return.
> >
> Thank you, Jeremy. I have modified my code. It is much simpler using
> that function. I am in the process of breaking my large patch up into
> smaller chunks and getting it merged into the upstream project at this
> time. Do I need to sign the license as I am an individual doing the work
> on my own and not for a company? I ask because the page you mentioned
> says I don't and I am wondering if it is out of date.

No, if it's your own work not for a company you don't need to
submit that document. Sorry for my misunderstanding you.

Cheers,

	Jeremy.



More information about the samba-technical mailing list