[PATCH] ctdb-daemon: Reset push_started flag once DB_PUSH is confirmed

Amitay Isaacs amitay at gmail.com
Wed Jun 8 13:52:53 UTC 2016


On Wed, Jun 8, 2016 at 5:37 PM, Ralph Boehme <slow at samba.org> wrote:

> On Wed, Jun 08, 2016 at 03:13:12PM +1000, Martin Schwenke wrote:
> > On Wed, 8 Jun 2016 15:10:08 +1000, Amitay Isaacs <amitay at gmail.com>
> > wrote:
> >
> > > Once DB_PUSH_START is processed as part of recovery, push_started
> > > flag tracks if there are multiple attempts to send DB_PUSH_START.
> > > In DB_PUSH_CONFIRM, once the record count is confirmed, all information
> > > related to DB_PUSH should be reset.  However, The push_started flag was
> > > not reset when the push_state was reset.
> > >
> > > Please review and push.
> >
> > Reviewed-by: Martin Schwenke <martin at meltin.net>
>
> is this an actual bug and so do we need to backport this one?
>
> Cheerio!
> -slow
>

It doesn't cause anything to fail, but does log annoying message.  I
already have a open defect to backport parallel recovery patches. I will
include this one too.

Amitay.


More information about the samba-technical mailing list