[PATCH] add a new error code when no ctdb after fork

[Peter Somogyi]

Hi,

Please accept this trivial patch - based on an error inject test when ctdb 
being killed.

We observe these messages with a large number of panics and core dumps - 
only that's what this patch intends to avoid:

[2016/05/20 10:31:53.632148,  0] ../source3/lib/dumpcore.c:318(dump_core)
  dumping core in /var/log/cnlog/samba/cores/smbd
[2016/05/20 10:31:53.634798,  1] 
../source3/lib/ctdbd_conn.c:298(ctdbd_connect)
  connect(/var/run/ctdb/ctdbd.socket) failed: Connection refused
[2016/05/20 10:31:53.634932,  1] 
../source3/lib/ctdbd_conn.c:450(ctdbd_init_connection)
  ctdbd_connect failed: Connection refused
[2016/05/20 10:31:53.634946,  1] 
../source3/lib/messages.c:418(messaging_reinit)
  messaging_ctdbd_init failed: NT_STATUS_CONNECTION_REFUSED
[2016/05/20 10:31:53.634960,  0] 
../source3/lib/util.c:483(reinit_after_fork)
  messaging_reinit() failed: NT_STATUS_CONNECTION_REFUSED
[2016/05/20 10:31:53.635002,  0] 
../source3/smbd/server.c:870(smbd_accept_connection)
  reinit_after_fork() failed
[2016/05/20 10:31:53.635175,  0] ../source3/lib/util.c:796(smb_panic_s3)
  PANIC (pid 53013): reinit_after_fork() failed
[2016/05/20 10:31:53.635806,  0] 
../source3/lib/util.c:907(log_stack_trace)
  BACKTRACE: 11 stack frames:
   #0 /usr/lib64/libsmbconf.so.0(log_stack_trace+0x1a) [0x7fa256c94b9a]
   #1 /usr/lib64/libsmbconf.so.0(smb_panic_s3+0x23) [0x7fa256c94c63]
   #2 /usr/lib64/libsamba-util.so.0(smb_panic+0x3a) [0x7fa25936f1da]
   #3 smbd(+0xa650) [0x7fa259a04650]
   #4 /usr/lib64/libsmbconf.so.0(run_events_poll+0x2b7) [0x7fa256caa787]
   #5 /usr/lib64/libsmbconf.so.0(+0x36bd6) [0x7fa256caabd6]
   #6 /usr/lib64/samba/libtevent.so.0(_tevent_loop_once+0x9d) 
[0x7fa2585f595d]
   #7 /usr/lib64/samba/libtevent.so.0(tevent_common_loop_wait+0x1b) 
[0x7fa2585f59db]
   #8 smbd(main+0x1fe2) [0x7fa259a06ab2]
   #9 /lib64/libc.so.6(__libc_start_ma

Tested so far at least that applying this patch won't hurt (reproduction 
is more hard).


--
Peter Somogyi
IBM Magyarországi Kft.
1117 Budapest
Infopark, Neumann János u. 1.
Hungary
Phone: +36 1 382 5469

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-yet-another-error-code-when-forking-an-smbd-and-.patch
Type: application/octet-stream
Size: 1140 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160603/f8775d22/0001-Add-yet-another-error-code-when-forking-an-smbd-and-.obj>