[PATCH] lib/util: Avoid splitting tevent-unix-util as public library

Amitay Isaacs amitay at gmail.com
Fri Jun 3 04:21:59 UTC 2016

On Thu, Jun 2, 2016 at 7:32 PM, Volker Lendecke <Volker.Lendecke at sernet.de>

> On Thu, Jun 02, 2016 at 05:49:54PM +1000, Amitay Isaacs wrote:
> > Hi,
> >
> > Commit 670db6ac1d678babd25dd82c4467c0f094cfabc5 split tevent-util public
> > library to create tevent-unix-util public library for standalone ctdb
> > use.  This created a public library dependency between samba and ctdb
> > for packaging.
> >
> > For now live with tevent-unix-util as a private library for ctdb.
> > Bundle tevent_unix.c in public library tevent-util as before.
> >
> > Please review and push.
> Question -- to me this looks as if you can't link both. What happens
> then for the tfd patches that might want to link against
> tevent-unix-util and then are linked in by smbd that also links in
> tevent-util. Haven't tried, but would that work?

Good point.  I forgot about the pending tfd patches.

I have reworked my fixes and are attached as ctdb.patches.
Now tevent-util is built as a private library for ctdb build with only
tevent_unix.c.  This is the same trick we use for samba-util.

I have also reworked your patches on top of the above fixes as vl.patches.
These fixes have following changes:

 - drop one patch which changed dependency from tevent-util to
 - rebase fix for my patch to expose few more subsystems
 - I have added fixup patch as suggested by Jeremy (can be squashed in)
 - A possible fixup to tfd in checking ret value (can be squashed in)

I would like to get your patches (with accept_send/recv and tfd) upstream
as soon as possible.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ctdb.patches
Type: application/octet-stream
Size: 5181 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160603/45a0961b/ctdb-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vl.patches
Type: application/octet-stream
Size: 104761 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160603/45a0961b/vl-0001.obj>

More information about the samba-technical mailing list