[PATCH] s3/client/clitar.c: always close fd

Andreas Schneider asn at samba.org
Thu Jun 2 05:34:46 UTC 2016


On Wednesday, 1 June 2016 16:46:23 CEST Jeremy Allison wrote:
> On Tue, May 31, 2016 at 04:00:04PM +0200, Andreas Schneider wrote:
> > On Tuesday, 31 May 2016 15:54:09 CEST Aurélien Aptel wrote:
> > > Hi,
> > > 
> > > Small fix #2, problem also found by coverity.
> > > 
> > > Please review&push, thanks!
> > 
> > Hi Aurélien,
> > 
> > thanks for your patch!
> > 
> > We avoid several goto targets in a function. I the fd should be
> > initialized
> > with -1 and then in out: do:
> > 
> > out:
> > 	if (fd != -1) {
> > 	
> > 		close(fd);
> > 	
> > 	}
> > 
> > Cheers,
> > 
> > 	-- andreas
> 
> Like this you mean ? :-).

RB+ :)

Pushed to autobuild

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org



More information about the samba-technical mailing list