[PATCH] Efficient xattr handling for VxFS

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed Jun 1 12:44:31 UTC 2016

On Wed, Jun 01, 2016 at 10:28:26AM +0000, Abhidnya Joshi wrote:
> Thanks for pointing this. Fixed it. Please find the changed patch.

lib_vxfs.c looks okay. However, there are a few points in vfs_vxfs.c.
First, the patch takes away the Symantec copyright notice.
www.symantec.com still does exist, so I assume the corporation is
still around.

Also, there are a lot of if-statements without braces. Apologies for
not seeing them in the first round of review. If you take a look at
the README.Coding document, Samba prefers braces everywhere to avoid
something like CVE-2014-1266.


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

SerNet & BSI laden ein: 29. Juni 2016,
2. IT-Grundschutztag 2016, BPA Berlin.
Anmeldung: https://www.sernet.de/gstag

More information about the samba-technical mailing list