[PATCH] winbindd logging fixes

Michael Adam obnox at samba.org
Wed Jun 1 10:12:52 UTC 2016


On 2016-06-01 at 12:08 +0200, Ralph Boehme wrote:
> On Wed, Jun 01, 2016 at 11:54:20AM +0200, Michael Adam wrote:
> > The change is good, but couldn't we make the logs more
> > useful by also writing out the object's name?
> 
> I brielfy thought about that too, but wanted to avoid the "error
> checking recursion" that adds, ie we'd then have to fetch some name
> attribute from the object with some func and add a error check if
> *that* func fails. :)

Oh, correct. In this loop we have only the result messages
since we are enumerating, and not even a dn or something.
So forget it ... :-)

Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160601/27167c01/signature.sig>


More information about the samba-technical mailing list