[PATCH] samba-tool throws error if there is an empty FSMO role

[Andrew Bartlett]

On Mon, 2016-05-30 at 21:32 +1200, Andrew Bartlett wrote:
> On Thu, 2016-05-26 at 10:19 +0100, Rowland Penny wrote:
> 
> > So, it seems to work for ad_dc_ntvfs:local and fl2000dc:local, but
> > fails 
> > for fl2003dc:local and fl2008r2dc:local.
> > Is this something I can change and if so, how? or am I running the
> > test 
> > incorrectly?
> 
> It just seems to be something wrong with those environments when run
> just for one test.  I can't explain it, but in the full make test it
> works fine, so I think we ignore it for now in the interests of
> getting
> your patch in.
> 
> Attached is your patches cleaned up (syntax error in the original
> patch, and didn't handle the fl2000dc case for me), and the tests. 
>  Please let me know if that is all OK and we can get this in to
> master.
> 
> Thanks for your patience here!
> 
> For others, the next step in testing this would be to validate the
> output.  I'm not asking that you do it before it gets in, but I do
> see
> it as the next logical step here.

Just as a heads-up to the list.  After my mail here, I looked over the
patches again, and I have taken some time to rework some elements. 
 I'll re-post them here when they are finished and tested, as they
address the mix of presentation and data issues.

Sorry for not getting that feedback to the list earlier.

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba