[PATCH] some cleanups

Martin Schwenke martin at meltin.net
Fri Jul 29 20:17:42 UTC 2016

On Fri, 29 Jul 2016 15:24:48 +0200, Volker Lendecke <vl at samba.org>

> Attached find some cleanups. I can't get them through a private
> autobuild, even master [...] reliably fails in
> tests/eventscripts/01.reclock.monitor.005.sh

Can you please post the failure?  It should be easy enough to find in
ctdb.stdout (and perhaps something unexpected in ctdb.stderr too).  It
passes for me/us in a variety of different environments. If the problem
is a subtle difference in output then you can get a diff between
expected and actual output by running:

  ./ctdb/tests/run_tests.sh -vD


> Maybe someone can take a look nevertheless.

Which compiler fails for the ctdb.c one?

First 2 patches:

Reviewed-by: Martin Schwenke <martin at meltin.net>

I'm not awake enough to understand the subtlety of switching the order
of the checks in the last hunk of the 3rd.  :-(

peace & happiness,

More information about the samba-technical mailing list