[PATCH] Improve performance of GUID_to_ndr_blob() and similar

Stefan Metzmacher metze at samba.org
Thu Jul 28 07:07:09 UTC 2016

Am 28.07.2016 um 05:14 schrieb Andrew Bartlett:
> On Mon, 2016-07-25 at 07:55 +0200, Volker Lendecke wrote:
>> On Mon, Jul 25, 2016 at 04:10:41PM +1200, Andrew Bartlett wrote:
>>> Here we avoid a talloc, reduce the other from 1024 to 16 bytes and
>>> avoid a talloc_steal().
>>> This helps in tight loops in the AD DC ldb layers, particularly
>>> during
>>> DRS replication of large numbers of links.  These O(N^2) loops
>>> should
>>> be addressed as well, but this fix will also help in many other
>>> cases. 
>>> Then, in the other patches, avoid talloc when not required
>>> elsewhere in
>>> ldb extended DN parsing.
>>> Please review and push.
>> This looks good, but I would like to see the attached diff applied
>> before it is pushed.
> I've fixed that in the attached.
> Please review/push!

I took
into my 4.5.0rc1 branch.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160728/ff8ba019/signature.sig>

More information about the samba-technical mailing list