Patches to unify ACL handling in vfs_ceph + vfs_gluster

Ira Cooper ira at wakeful.net
Wed Jul 27 20:33:20 UTC 2016


Any chance someone can confirm this works and RB+ this?

-Ira

On Tue, Jul 26, 2016 at 1:38 PM, Ira Cooper <ira at wakeful.net> wrote:

> Try this Steve.  It should fix the issue.
>
> Cheers,
>
> -Ira
>
> On Tue, Jul 26, 2016 at 2:22 AM, Steve French <smfrench at gmail.com> wrote:
>
>> Samba master is broken due to recent ACL changes, even if you build
>> with "--without-acl-support" it tries to pull in 'acl' for
>> POSIXACL_XATTR
>>
>> On Tue, Jul 26, 2016 at 1:08 AM, Steve French <smfrench at gmail.com> wrote:
>> > With master updated with the recent ACL changes in the last five days,
>> > I noticed a build break on master (our builds have richacl enabled,
>> > but don't include posix acl).  Even on RHEL7 this will fail
>> > (libacl-devel is installed, but acls aren't enabled).  See excerpts
>> > from configure tests relating to ACLs below:
>> >
>> > 23:43:35 Checking for header acl/libacl.h                             :
>> yes
>> > 23:43:36 Checking for header sys/acl.h                                :
>> yes
>> > 23:44:30 Checking for _acl
>> >                                   : not found
>> > 23:44:30 Checking for __acl
>> >                                   : not found
>> > 23:44:30 Checking for chmod
>> >                                   : ok
>> > 23:44:31 Checking for _facl
>> >                                   : not found
>> > 23:44:31 Checking for __facl
>> >                                   : not found
>> > 23:44:36 building on linux2
>> > 23:44:36 Checking for header sys/richacl.h
>> >                                   : yes
>> > 23:44:36 Checking for library richacl
>> >                                   : yes
>> > 23:44:36 Checking for richacl_get_file
>> >                                   : ok
>> > 23:44:36 Using Linux RICHACLs
>> > ...
>> >
>> > 23:44:49 Checking project rules ...
>> > 23:44:49 Unknown dependency 'acl' in 'POSIXACL_XATTR'
>> >
>> > On Fri, Jul 22, 2016 at 5:20 PM, Jeremy Allison <jra at samba.org> wrote:
>> >> On Thu, Jul 21, 2016 at 08:47:07PM -0400, Ira Cooper wrote:
>> >>> Forgot to git commit --amend that one :/.
>> >>>
>> >>> I have the exact same fix locally.
>> >>>
>> >>> Just passed my local build.
>> >>
>> >> LGTM. Pushed !
>> >>
>> >
>> >
>> >
>> > --
>> > Thanks,
>> >
>> > Steve
>>
>>
>>
>> --
>> Thanks,
>>
>> Steve
>>
>
>


More information about the samba-technical mailing list