[PATCH] shadow_copy2: Allow configurable prefix for snapshots
Rajesh Joseph
rjoseph at redhat.com
Wed Jul 27 15:11:44 UTC 2016
Thanks Michael, Ira and Uri for the great review and help.
Thanks & Regards,
Rajesh
On Wed, Jul 27, 2016 at 8:27 PM, Michael Adam <obnox at samba.org> wrote:
> pushed the attached patchset to autobuild
>
> Michael
>
> On 2016-07-27 at 15:59 +0200, Michael Adam wrote:
> > On 2016-07-22 at 15:35 +0200, Michael Adam wrote:
> > > On 2016-07-22 at 12:00 +0300, Uri Simchoni wrote:
> > > > Hi Rajesh,
> > > >
> > > > RB+ me.
> > > >
> > > > Can I get another Team reviewer?
> > >
> > > I have started to (re-)review.
> > >
> > > Thanks for the excellent review comments, btw, Uri!
> > > I will comment or push later today.
> >
> > Reviewed-by: me.
> >
> > I have made a few super minor comment formatting
> > adjustments (we usually do this as a function
> > header comment block:
> >
> > /**
> > * comment
> > * comment
> > * ...
> > */
> > ) But otherwise this looks great.
> > Ah, I fixed a xml tag mixup
> > (variablelist closed too early) in the manpage
> > as already spotted by Ira.
> >
> > Gonna push after a local build/test.
> >
> > Cheers - Michael
> >
>
>
>
More information about the samba-technical
mailing list