[PATCH] shadow_copy2: Allow configurable prefix for snapshots

Michael Adam obnox at samba.org
Wed Jul 27 13:59:35 UTC 2016


On 2016-07-22 at 15:35 +0200, Michael Adam wrote:
> On 2016-07-22 at 12:00 +0300, Uri Simchoni wrote:
> > Hi Rajesh,
> > 
> > RB+ me.
> > 
> > Can I get another Team reviewer?
> 
> I have started to (re-)review.
> 
> Thanks for the excellent review comments, btw, Uri!
> I will comment or push later today.

Reviewed-by: me.

I have made a few super minor comment formatting
adjustments (we usually do this as a function
header comment block:

/**
 * comment
 * comment
 * ...
 */
) But otherwise this looks great.
Ah, I fixed a xml tag mixup
(variablelist closed too early) in the manpage
as already spotted by Ira.

Gonna push after a local build/test.

Cheers - Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160727/d5e50bcb/signature.sig>


More information about the samba-technical mailing list