[PATCH] Miscellaneous CTDB improvements

[Stefan Metzmacher]

Am 27.07.2016 um 08:15 schrieb Amitay Isaacs:
> On Wed, Jul 27, 2016 at 12:39 PM, Amitay Isaacs <amitay at gmail.com> wrote:
> 
>> On Tue, Jul 26, 2016 at 8:11 PM, Martin Schwenke <martin at meltin.net>
>> wrote:
>>
>>> 3 things here (in 5 commits):
>>>
>>> * ctdb_diagnostics(1) manpage - this has been in the queue for too long
>>>
>>> * Use a cumulative timeout for IP takeover runs - avoids RELEASE_IP
>>>   timeouts due to taking a long time to kill TCP connections while
>>>   still keeping the overall time limit the same
>>>
>>> * Move a struct to the only file it is used in
>>>
>>> Please review and maybe push...
>>>
>>> peace & happiness,
>>> martin
>>>
>>
>> Reviewed-by: me.
>>
>> Amitay.
>>
> 
> Pushed to autobuild.

I added your autobuild to mine and it fails to build the

samba-ctdb target:

[2750/4194] Compiling ctdb/common/tunable.c
In file included from /usr/include/rpc/netdb.h:42:0,
                 from /usr/include/netdb.h:32,
                 from ../lib/replace/system/network.h:54,
                 from ../ctdb/common/tunable.c:22:
../ctdb/common/tunable.c:155:19: error: excess elements in struct
initializer [-Werror]
   offsetof(struct ctdb_tunable_list, queue_buffer_size), false },
                   ^
../ctdb/common/tunable.c:155:19: error: (near initialization for
‘tunable_map[59]’) [-Werror]
cc1: all warnings being treated as errors
Waf: Leaving directory `/memdisk/metze/a/b947801/samba-ctdb/bin'
Build failed:  -> task failed (err #1):
        {task: cc tunable.c -> tunable_5.o}
make: *** [all] Error 1


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160727/40ca3d81/signature.sig>