[PATCH] Making shares unaccessible at root level mountable (aka solving bsc#8950 ...again)

Steve French smfrench at gmail.com
Tue Jul 26 18:04:44 UTC 2016


thoughts on stable?

On Wed, Jul 20, 2016 at 1:28 PM, Pavel Shilovsky <piastryyy at gmail.com> wrote:
> 2016-07-20 15:16 GMT+03:00 Aurélien Aptel <aaptel at suse.com>:
>> On Wed, 20 Jul 2016 12:57:02 +0200 Aurélien Aptel <aaptel at suse.com>
>> wrote:
>>> Oops. Okay this time checkpatch.pl only complains about a quoted
>>> string split across lines wich I'm not really sure how to fix so I'm
>>> leaving that as is.
>>
>> ...because not splitting it would make the line >80 chars. The whole
>> point of doing this is AFAIU to be able to grep the message so using "\"
>> wouldn't fix it really.
>>
>> --
>> Aurélien Aptel / SUSE Labs Samba Team
>> GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
>> SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
>> GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG
>> Nürnberg)
>
> The quoted string should not be split even if it is >80 chars.
>
> Anyway, the patch looks good. Thanks for fixing this long-term issue.
>
> Reviewed-by: Pavel Shilovsky <pshilovsky at samba.org>
>
> --
> Best regards,
> Pavel Shilovsky



-- 
Thanks,

Steve



More information about the samba-technical mailing list